Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coupling #335

Closed
AustinShalit opened this issue Nov 17, 2019 · 4 comments
Closed

Improve coupling #335

AustinShalit opened this issue Nov 17, 2019 · 4 comments

Comments

@AustinShalit
Copy link
Member

Some examples of using the PIDController in different situations (drive, lift, arm) would also be helpful. The same is true for the kinematic classes. For example, the documentation in https://frc-docs.readthedocs.io/ did not give guidance on where to use the kinematic classes and how they fit in with any other packages. I ended up looking at some of the updated example code to get a better idea. A few more links to relevant coding examples within the documentation would help greatly.

@Daltz333
Copy link
Member

Is this still valid with the incorporation of the examples section?

@AustinShalit
Copy link
Member Author

I think so. More examples would help here.

@Daltz333
Copy link
Member

Daltz333 commented Apr 3, 2021

Some examples of using the PIDController in different situations (drive, lift, arm) would also be helpful.

Using and Tuning a PIDController

For example, the documentation in frc-docs.readthedocs.io did not give guidance on where to use the kinematic classes and how they fit in with any other packages. I ended up looking at some of the updated example code to get a better idea. A few more links to relevant coding examples within the documentation would help greatly.

The kinematic articles as is very briefly outlies what they are and are focused on implementation. They do not go into why the user should use them, or common usecases. They should get expanded or detailed.

@Daltz333
Copy link
Member

Daltz333 commented Apr 3, 2021

Closed in favor of
#1290
#1291

@Daltz333 Daltz333 closed this as completed Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants