Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct FRC acronym branding #250

Open
Kevin-OConnor opened this issue Oct 8, 2019 · 18 comments · Fixed by #983 or #1027
Open

Correct FRC acronym branding #250

Kevin-OConnor opened this issue Oct 8, 2019 · 18 comments · Fixed by #983 or #1027

Comments

@Kevin-OConnor
Copy link
Contributor

The registered trademark symbol should be added to the first use of the FRC acronym in body text on any page where it appears.

This can be accomplished by using

..include:: <isonum.txt> at the top of the document and the using FRC\ |reg| at the first usage of the acronym

@sciencewhiz
Copy link
Collaborator

There should be a space between .. and include: .. include:: <isonum.txt>

@Daltz333
Copy link
Member

Are there areas where this is still needed? Can someone do a grep?

@AustinShalit
Copy link
Member

(Checking acronym formatting would be a great candidate for a check in CI. It could also check all of the other acronyms that we use)

@Daltz333
Copy link
Member

I think that would be best as part of a formatter. #228

@jasondaming
Copy link
Member

So what all does this apply to. I see:
FIRST
FRC
any others? (I would imagine it could (maybe should) apply to: Microsoft, NI, Axis, CTRE, Vex, etc.

@jasondaming
Copy link
Member

what about the FRC Game Manual at the top of every page? I assume that needs it too?

@jasondaming
Copy link
Member

does frc-docs need to have it also?

@Daltz333
Copy link
Member

Daltz333 commented Dec 6, 2020

frc-docs is creative commons with limitations. Additionally the acronym is only required in certain contexts.

@jasondaming
Copy link
Member

Note that the ..include:: <isonum.txt> mentioned above will not work. There must be a space between .. and include

@ofekashery
Copy link
Contributor

FRC® is the former name and it should appear as little as possible in official use.
According to the FIRST Branding, it should be written out as FIRST® Robotics Competition, not FRC.

@Daltz333
Copy link
Member

That's not really feasible for us. @Kevin-OConnor can you confirm

@Kevin-OConnor
Copy link
Contributor Author

Yes, we are trying to minimize use of the acronym, why is it not feasible?

@Kevin-OConnor Kevin-OConnor reopened this Dec 10, 2020
@Daltz333
Copy link
Member

  1. We probably don't want translators to translate it
  2. Seems to add a lot of extra verbosity. Can we use FRC in titles? Or should we just avoid using FRC/FIRST Robotics Competition at all in titles.

@jasondaming
Copy link
Member

jasondaming commented Dec 10, 2020

I currently count 1514 uses of FRC in the docs. Not to mention all of the Titles and such it would legthen immensely. That counts links too so it isn't really that high...but it is a lot

@Daltz333
Copy link
Member

We can do it, but it'd be a long term thing to work toward. I think an appropriate short-term solution would be added a notice to the style guide to avoid FRC/FIRST Robotics Competition in titles, and use FIRST Robotics Competition as we go, updating references in documents that are updated. Or we could use the spell-checker to warn on updated documentation to update.

@Kevin-OConnor
Copy link
Contributor Author

I agree, I am not suggesting we just Find/Replace it as that will add a ton of length. I think it is a longer term trying to rephrase things to say it less if they're being touched anyway kind of thing.

@Daltz333
Copy link
Member

I think the following will close this issue:

  1. Add a notice to the style guide to use FIRST Robotics Competition and not FRC. Do not use either in titles.
  2. Add someway (Github actions check) to flag certain spellings of words (FRC) and to use alternative. Perhaps a tool like wpiformat. A simple python script in scripts would be fine.

@Kevin-OConnor
Copy link
Contributor Author

Yep, that sounds reasonable

@Daltz333 Daltz333 linked a pull request Dec 26, 2020 that will close this issue
@Daltz333 Daltz333 reopened this Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants