-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update translation guidelines for common pitfalls #2313
Comments
Initial investigation leads that the translation is correctly getting synced to GitHub. You can see it's visible here, time to investigate why RTD is failing https://github.com/wpilibsuite/frc-docs-translations/blob/main/locale/ja/LC_MESSAGES/docs/zero-to-robot/step-4/creating-test-drivetrain-program-cpp-java.po |
I replaced the text in transifex with a different translation (well not really a translation at all), to see if RTD was failing on some portion of the text. |
The testing translation succeeded, so there is something about that specific string it's angry with |
I checked the unicode and it doesn't seem to be using any particularly weird characters. I removed the leading space so I guess I can see if that's the problem... |
@Daltz333 It look like the space at the beginning might have been the issue -- it looks like Transifex supports lint/error-checks for spaces at the beginning and end of source and translation strings. Would it be possible to enable that (at least as a warning)? Seems like it would be helpful if spaces at the start of a string quietly disable the translation. As a note for context, Japanese essentially doesn't use the space character (even visual "spaces" are typically padding on a non-space character), however the space character is required by the reStructuredText parser to detect special directives (in this case, the To illustrate a bit more, here are a few contrived examples: Valid
Invalid
Japanese strings are much closer to the invalid case. I would guess other languages have similar limitations, so it might be a good note for the translations contributing page. |
Overview
Description
It appears one resource explaining how to use the command palette in VS code is not being replaced on this page. I don't have any other immediate examples on hand, but I can only imagine that whatever is causing this string not to translate may be affecting other resources as well.
What I've Tried
Documentation
Direct link: https://docs.wpilib.org/ja/latest/docs/zero-to-robot/step-4/creating-test-drivetrain-program-cpp-java.html
Translation reviewed 12+ days ago:
Current State:
Additional Info
I am open to doing work to resolve this from the code side (e.g. submitting a PR), but I would need support from wpilib first to root-cause the issue. The integration with the translation service is not clear to me and I am not sure if this is even something that can be fixed via PR.
The text was updated successfully, but these errors were encountered: