Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Compatibility of WooCommerce Extensions with Translation Loading Changes in WordPress 6.7 #258

Open
Sourabh208 opened this issue Dec 17, 2024 · 4 comments · May be fixed by #269
Open

Test Compatibility of WooCommerce Extensions with Translation Loading Changes in WordPress 6.7 #258

Sourabh208 opened this issue Dec 17, 2024 · 4 comments · May be fixed by #269
Assignees
@iamdharmesh @MiguelAxcar
Labels
priority: high The issue/PR is high priority—if affect lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.
Milestone
Future Release

Comments

@Sourabh208
Copy link

WordPress 6.7 introduces updates to how translations are loaded. These changes may impact WooCommerce extensions that rely on localized strings. To ensure compatibility, we need to test all extensions to verify that translations load correctly without errors.

Developer advisory: Translation loading changes in WordPress 6.7

Image

Steps to Test Extensions Compatibility with Translation Changes

  1. Install WordPress 6.7.1, WooCommerce, and the WooCommerce extension(s) in a local environment with SSL enable.
  2. Enable WP Debug mode.
  3. Change the site language in Settings > General > Site Language to a non-English language with available translations.
  4. Verify that translations load correctly in the WooCommerce admin settings and back-end areas.
  5. Check the front-end functionality of the extension to ensure user-facing strings are translated properly.
  6. Check the server and WordPress debug logs for errors related to translation loading.
  7. Document any issues, errors, or log warnings in the below comment on this issue.
  8. Expected Result: All strings are correctly translated and no errors are found in log or admin area.

Related Discussion- https://fueled10up.slack.com/archives/C01UCQGPBDJ/p1733327894925469
@Sourabh208 Sourabh208 self-assigned this Dec 17, 2024
@Sourabh208
Copy link
Author

Sourabh208 commented Dec 17, 2024 •
edited
Loading

QA Status: ❌

Testing Environment - Local

  • WordPress: 6.7
  • Theme active on store: Twenty Twenty-Five
  • WooCommerce - Version 9.4.1 
  • PHP: 8.2.23 
  • Web Server: nginx/1.26.1
  • Browser: Chrome - Version 128
  • OS: macOS Sonoma 14.6.1
  • Square : Version 4.8.4
  1. Verify the Notice Function _load_textdomain_just_in_time should not present for Square Extension ❌ Able to see the error after translation.
Image

@ankitguptaindia
Copy link
Member

@vikrampm1 this extension requires fixes. Please assign this for the next step.

@vikrampm1 vikrampm1 added priority: high The issue/PR is high priority—if affect lots of customers substantially, but not critically. type: bug The issue is a confirmed bug. labels Dec 18, 2024
@MiguelAxcar MiguelAxcar self-assigned this Dec 20, 2024
@MiguelAxcar
Copy link
Contributor

Hello @Sourabh208,

I invested a lot of time testing various scenarios, but unfortunately, I wasn't able to reproduce the issue.

Environment

  • WordPress: 6.7.1
  • Active Theme: Twenty Twenty-Five (also tested with TT4 and Storefront)
  • WooCommerce: 9.4.1 (also tested 9.5.1)
  • Language: Tested on English and non-English languages
  • PHP: 8.2.23 (also tried 8.1 and 8.3)
  • Web Server: nginx
  • Browser: Chrome 131.0.6778.204
  • OS: GNU/Linux Debian
  • Square: 4.8.4

Deprecation Warnings

Image

As you can see, I encountered some deprecation dynamic properties messages. I also forced a USER_NOTICE error to confirm WordPress is properly outputting errors.

Do you have anything specific in your local environment that could help me replicate this? It's also unexpected for me that you're not seeing these deprecation warnings.

One option I can see is for you to export your local site, upload it to Google Drive, and share it with me. Alternatively, we could schedule a quick call after the holidays to troubleshoot this together. If we're in different time zones, I'm happy to adjust to yours.

Let me know if you have any other ideas or suggestions.

Thank you!

@Sourabh208
Copy link
Author

Hello @MiguelAxcar ,

  • Testing Environment - Local
  • WordPress: 6.7
  • Theme active on store: Twenty Twenty-Five
  • WooCommerce - Version 9.4.1
  • PHP: 8.2.23
  • Web Server: nginx/1.26.1
  • Browser: Chrome - Version 128
  • OS: macOS Sonoma 14.6.1
  • Square: Version 4.8.4

I've got the above configuration in my local environment. Also, as you asked, I've shared the zip file of the local folder with you so you can explore it more. I'm working in the IST time zone. We can connect when you come back from holiday breaks. I am happy to adjust as per yours.

Drive folder link: https://drive.google.com/file/d/1HKIkCa8_J9Qw9_Zt5Q1jIQ6mKQfIvZqL/view?usp=drive_link

Image

@iamdharmesh iamdharmesh linked a pull request Jan 13, 2025 that will close this issue
Draft
4 tasks
@iamdharmesh iamdharmesh self-assigned this Jan 13, 2025
@iamdharmesh iamdharmesh added this to the Future Release milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamdharmesh iamdharmesh

@MiguelAxcar MiguelAxcar

Labels
priority: high The issue/PR is high priority—if affect lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
Future Release
5 participants
@ankitguptaindia @iamdharmesh @MiguelAxcar @vikrampm1 @Sourabh208