Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate PRB settings data to ECE #3711

Open
Mayisha opened this issue Jan 10, 2025 · 0 comments
Open

Migrate PRB settings data to ECE #3711

Mayisha opened this issue Jan 10, 2025 · 0 comments
Labels
component: ECE Issues related to Express Checkout Element priority: medium The issue/PR is medium priority—it affects lots of customers substantially, but not critically. type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@Mayisha
Copy link
Contributor

Mayisha commented Jan 10, 2025 •
edited
Loading

Currently, we are using the payment_request_* object of Stripe settings data for express checkout. For express checkout, we should store the settings data in its own express_checkout_* object. To ensure a site's express checkout settings persists after we change the attribute name, we need to migrate the payment request settings data to express checkout settings data.

In this PR we had implemented the migration #3688. But we had to undo some of the changes in #3699 and #3705 as it caused a bug where the legacy checkout experience was getting set as default instead of the new checkout experience.

Acceptance Criteria

  • Create and run the migration script for all accounts.
  • Ensure that the bug regarding the legacy checkout experience does not resurface.

cc: @wjrosa
@wjrosa wjrosa added type: technical debt This issue/PR represents/solves the technical debt of the project. component: ECE Issues related to Express Checkout Element priority: medium The issue/PR is medium priority—it affects lots of customers substantially, but not critically. labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ECE Issues related to Express Checkout Element priority: medium The issue/PR is medium priority—it affects lots of customers substantially, but not critically. type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wjrosa @Mayisha