Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blur with alpha looking wonky #77

Open
ErikReider opened this issue Nov 15, 2024 · 2 comments
Open

Fix blur with alpha looking wonky #77

ErikReider opened this issue Nov 15, 2024 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@ErikReider
Copy link
Member

We probably would need to interpolate between the original texture and the blurred texture when adjusting the alpha of the blur?

Image of alpha 0.9, blur passes 3, and blur radius set to 5:
image

@ErikReider ErikReider added the bug Something isn't working label Nov 15, 2024
@WillPower3309
Copy link
Member

Hmm this worked fine on swayfx with my animations branch (where we update the blur alpha with the tex alpha for fade in/ out). Wonder what's going wrong here

@WillPower3309 WillPower3309 added this to the scenefx 1.0 milestone Nov 17, 2024
@dqrk0jeste
Copy link

dqrk0jeste commented Jan 28, 2025

i think this is the issue i have faced. when using low opacity values (set using wlr_scene_buffer_set_opacity()), they would affect the blur as well, so the original background would be seen more than the blur.

i guess you currently do blur by composing it into the buffer. would it be possible to first apply opacity settings to the original buffer, and then compose the blur after? that way seems more natural and i guess it would look better.

edit:

they would affect the blur as well

the way it is now, xray effect is lost when opacity is applied to the buffer, so i think my assumption is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants