From c9991a9d1c29ea2dd4328317f75aeb144923747e Mon Sep 17 00:00:00 2001
From: Domenic Denicola <d@domenic.me>
Date: Wed, 15 Jan 2025 15:00:09 +0900
Subject: [PATCH 1/2] Fix url and src in NotRestoredReasons

url was previously listed as a DOMString, but it should be a USVString. This change is not observable since it always contained a serialized URL anyway.

src was previously listed as containing the literal value of the src="" content attribute. However, the intended behavior was to contain the parsed-then-serialized value of the src IDL attribute, i.e., the result after content/IDL attribute reflection. Fix the spec to reflect that, which allows also changing it to USVString.

Finally, also account for the fact that sometimes content attributes can be missing, in which case these properties need to return the empty string. (Not null, which is reserved for the top level or non-iframe child cases.)

Closes #10895.
---
 source | 41 +++++++++++++++++++++++++++++------------
 1 file changed, 29 insertions(+), 12 deletions(-)

diff --git a/source b/source
index 5ac4faf7eb7..844c33a2917 100644
--- a/source
+++ b/source
@@ -96948,10 +96948,10 @@ interface <dfn interface>NotRestoredReasonDetails</dfn> {
 
 [Exposed=Window]
 interface <dfn interface>NotRestoredReasons</dfn> {
-  readonly attribute DOMString? <span data-x="dom-not-restored-reasons-src">src</span>;
+  readonly attribute USVString? <span data-x="dom-not-restored-reasons-src">src</span>;
   readonly attribute DOMString? <span data-x="dom-not-restored-reasons-id">id</span>;
   readonly attribute DOMString? <span data-x="dom-not-restored-reasons-name">name</span>;
-  readonly attribute DOMString? <span data-x="dom-not-restored-reasons-url">url</span>;
+  readonly attribute USVString? <span data-x="dom-not-restored-reasons-url">url</span>;
   readonly attribute FrozenArray&lt;<span>NotRestoredReasonDetails</span>&gt;? <span data-x="dom-not-restored-reasons-reasons">reasons</span>;
   readonly attribute FrozenArray&lt;<span>NotRestoredReasons</span>&gt;? <span data-x="dom-not-restored-reasons-children">children</span>;
   [Default] object toJSON();
@@ -97395,7 +97395,8 @@ interface <dfn interface>NotRestoredReasons</dfn> {
   the following <span data-x="struct item">items</span>:</p>
 
   <ul>
-   <li><p><dfn data-x="nrr-src">src</dfn>, a string or null, initially null.</p></li>
+   <li><p><dfn data-x="nrr-src">src</dfn>, a <span>scalar value string</span> or null, initially
+   null.</p></li>
 
    <li><p><dfn data-x="nrr-id">id</dfn>, a string or null, initially null.</p></li>
 
@@ -104757,22 +104758,38 @@ location.href = '#foo';</code></pre>
    <li><p>Set <var>notRestoredReasonsForDocument</var>'s <span data-x="nrr-url">URL</span> to
    <var>document</var>'s <span data-x="concept-document-url">URL</span>.</p></li>
 
+   <li><p>Let <var>container</var> be <var>document</var>'s <span>node navigable</span>'s <span
+   data-x="nav-container">container</span>.</p></li>
+
    <li>
-    <p>If <var>document</var>'s <span>node navigable</span>'s <span
-    data-x="nav-container">container</span> is an <code>iframe</code> element, then:</p>
+    <p>If <var>container</var> is an <code>iframe</code> element:</p>
 
     <ol>
+     <li><p>Let <var>src</var> be the empty string.</p></li>
+
+     <li>
+      <p>If <var>container</var> has a <code data-x="dom-iframe-src">src</code> attribute:</p>
+
+      <ol>
+       <li><p>Let <var>src</var> be the result of <span>encoding-parsing-and-serializing a
+       URL</span> given <var>container</var>'s <code data-x="attr-iframe-src">src</code> attribute's
+       value.</p></li>
+
+       <li><p>If <var>src</var> is failure, then set <var>src</var> to <var>container</var>'s <code
+       data-x="attr-iframe-src">src</code> attribute's value.</p></li>
+      </ol>
+     </li>
+
      <li><p>Set <var>notRestoredReasonsForDocument</var>'s <span data-x="nrr-src">src</span> to
-     the value of <var>document</var>'s <span>node navigable</span>'s <span
-     data-x="nav-container">container</span>'s <code data-x="attr-iframe-src">src</code> attribute.</p></li>
+     <var>src</var>.</p></li>
 
      <li><p>Set <var>notRestoredReasonsForDocument</var>'s <span data-x="nrr-id">id</span> to
-     the value of <var>document</var>'s <span>node navigable</span>'s <span
-     data-x="nav-container">container</span>'s <code data-x="attr-id">id</code> attribute.</p></li>
+     <var>container</var>'s <code data-x="attr-id">id</code> attribute's value, or the empty string
+     if it has no such attribute.</p></li>
 
-     <li><p>Set <var>notRestoredReasonsForDocument</var>'s <span data-x="nrr-name">name</span>
-     to the value of <var>document</var>'s <span>node navigable</span>'s <span
-     data-x="nav-container">container</span>'s <code data-x="attr-iframe-name">name</code> attribute.</p></li>
+     <li><p>Set <var>notRestoredReasonsForDocument</var>'s <span data-x="nrr-name">name</span> to
+     <var>container</var>'s <code data-x="attr-iframe-name">name</code> attribute's value, or the
+     empty string if it has no such attribute.</p></li>
     </ol>
    </li>
 

From 3475390363b48503877529fadd0b2acd1b1ea1b5 Mon Sep 17 00:00:00 2001
From: Domenic Denicola <d@domenic.me>
Date: Wed, 15 Jan 2025 16:15:13 +0900
Subject: [PATCH 2/2] Missed "relative to"

---
 source | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source b/source
index 844c33a2917..ea5cd16a5fc 100644
--- a/source
+++ b/source
@@ -104773,7 +104773,7 @@ location.href = '#foo';</code></pre>
       <ol>
        <li><p>Let <var>src</var> be the result of <span>encoding-parsing-and-serializing a
        URL</span> given <var>container</var>'s <code data-x="attr-iframe-src">src</code> attribute's
-       value.</p></li>
+       value, relative to <var>container</var>'s <span>node document</span>.</p></li>
 
        <li><p>If <var>src</var> is failure, then set <var>src</var> to <var>container</var>'s <code
        data-x="attr-iframe-src">src</code> attribute's value.</p></li>