Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify differing assertions between show and showModal #10921

Open
lukewarlow opened this issue Jan 16, 2025 · 1 comment
Open

Clarify differing assertions between show and showModal #10921

lukewarlow opened this issue Jan 16, 2025 · 1 comment
Assignees
@mfreed7
Labels
clarification Standard could be clearer topic: dialog The <dialog> element

Comments

@lukewarlow
Copy link
Member

What is the issue with the HTML Standard?

In dialog.show() step 7 adds this to the open dialogs list.

In dialog.showModal() step 13 first asserts that open dialogs list doesn't already contain this, before step 14 adds this to that list.

I would have expected these to both have the same expectations of what is valid state or not, so I just wanted to clarify if there was a reason for this that I'm missing?
@lukewarlow lukewarlow added clarification Standard could be clearer topic: dialog The <dialog> element labels Jan 16, 2025
@domenic
Copy link
Member

domenic commented Jan 17, 2025

This was added as part of 8029d4f, so assigning to @mfreed7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfreed7 mfreed7

Labels
clarification Standard could be clearer topic: dialog The <dialog> element
Milestone
No milestone
Development

No branches or pull requests
3 participants
@domenic @mfreed7 @lukewarlow