[Accessibility] - Test for elements not in viewport contained within content-visibility: auto CSS property #50004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
cookiecrook,
jnurthen,
MelSumner and
spectranaut
|
Results:
|
cookiecrook
requested changes
Jan 15, 2025
Comment on lines
39
to
43
| promise_test(async t => { | ||
| let computedLabel = await test_driver.get_computed_label(el); | ||
| let computedRole = await test_driver.get_computed_role(el); | ||
|
|
||
| console.log('el-text-content: '+el.textContent+'; comp-role-f: '+computedRole+'; comp-label-f: '+computedLabel); |
There was a problem hiding this comment.
You can still use the existing aria utils logging to abstract this... Just leave the expected role and labels as something no engine will ever use, like data-expectedrole="SPEC_AMBIGUOUS_LOG_VALUE" and all engines will log a message like ~"Role for for element was group; Expected: SPEC_AMBIGUOUS_LOG_VALUE"
There was a problem hiding this comment.
Is it acceptable for all engines to fail, even if the outcome is uncertain?
Comment on lines
27
to
29
| <h2 class="el">test heading</h2> | ||
| <button class="el">test button</button> | ||
| <a class="el" href="#">test link</a> |
There was a problem hiding this comment.
needs data-expectedrole="heading", etc.
cookiecrook
reviewed
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: web-platform-tests/interop-accessibility#168
Relates: w3c/html-aam#572
This PR introduces tests for elements outside the viewport that are contained within another element with the content-visibility: auto CSS property. The console log output includes:
Note: The test outcomes are simply logs to observe browser behavior. There are no set expectations at this point, as these will be discussed in relation to w3c/html-aam#572.