Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing <p> ids in security recommendations #2533

Closed
GJFR opened this issue Mar 2, 2023 · 3 comments
Closed

Missing <p> ids in security recommendations #2533

GJFR opened this issue Mar 2, 2023 · 3 comments
Labels
EPUB33 Issues addressed in the EPUB 3.3 revision

Comments

@GJFR
Copy link
Contributor

GJFR commented Mar 2, 2023

Paragraphs containing normative statements in the Recommendations section concerning security and privacy seem to be missing id attributes.

I suspect id attributes should be added if these statements are to be tested, such that each test's package.opf file can refer to the specific statement by using the id as an anchor tag?

@iherman
Copy link
Member

iherman commented Mar 3, 2023

@GJFR, the practice we have is to add an ID (and a reference to the test) when a test is added to the test suite itself. Ie, a separate Pull Request will be necessary on the recommendation spec, adding not only an ID but also a reference to the test.

If it is a hurdle, do not worry about it now. If you have a proper test (thanks for it!) then I am happy to make the necessary adjustments.

@GJFR
Copy link
Contributor Author

GJFR commented Mar 3, 2023

OK, thanks for the clarification @iherman! Was not sure whether normative statements without such an ID were intended to be tested.

@iherman
Copy link
Member

iherman commented Mar 13, 2023

Closing as resolved via several PR-s on the matter (e.g., #2527 and friends)

@iherman iherman closed this as completed Mar 13, 2023
@mattgarrish mattgarrish added the EPUB33 Issues addressed in the EPUB 3.3 revision label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPUB33 Issues addressed in the EPUB 3.3 revision
Projects
None yet
Development

No branches or pull requests

3 participants