Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): unwrap refs in mapWritableState for setup stores #2805

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

jh-leong
Copy link
Member

close #2804

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for pinia-official canceled.

Name Link
🔨 Latest commit fe6f21b
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/671b57d0f3906400084432f1

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for pinia-playground ready!

Name Link
🔨 Latest commit fe6f21b
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/671b57d0b8f8f600085ac948
😎 Deploy Preview https://deploy-preview-2805--pinia-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Oct 25, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/pinia@2805
pnpm add https://pkg.pr.new/@pinia/testing@2805
pnpm add https://pkg.pr.new/@pinia/nuxt@2805

commit: fe6f21b

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.11%. Comparing base (6fb480e) to head (fe6f21b).

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #2805      +/-   ##
==========================================
+ Coverage   89.67%   90.11%   +0.44%     
==========================================
  Files          14       14              
  Lines        1336     1336              
  Branches      218      220       +2     
==========================================
+ Hits         1198     1204       +6     
+ Misses        137      131       -6     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 Triaging
Development

Successfully merging this pull request may close these issues.

mapWritableState on setup stores doesn't unwrap refs
1 participant