Skeleton.interBoneValidations
should be replaced by something useful
#1207
Labels
Priority: Medium
This issue may be useful, and needs some attention.
proposal
refactoring
Pull requests that refactor code but do not change its behavior.
usability
interBoneValidations
is one of the ugliest pieces in ViUR. It was intended to be used in the Skeleton to run validations on skeleton-level.Levels of ugliness:
interBoneValidations
is ugly and misleadingReadFromClientError
?Everywhere I've being used it, it looked liked this:
So in the end, it can be just a subclass-able hook function, let's call it just
validate
, which does the same, and belongs to the Skeleton class.Proposal:
This relates to #630 as well, which defines a well named and clear CRUD naming convention.
The text was updated successfully, but these errors were encountered: