Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type for query order #1115

Open
sveneberth opened this issue Mar 19, 2024 · 0 comments
Open

Add type for query order #1115

sveneberth opened this issue Mar 19, 2024 · 0 comments
Labels
Priority: Low This issue can be considered with enough idle time. python Pull requests that update Python code refactoring Pull requests that refactor code but do not change its behavior.
Milestone
ViUR-core v3.8

Comments

@sveneberth
Copy link
Member

I think when the Query class gets back to viur-core again, we should re-define the order-tuple to a namedtuple or dataclass, so that it has a clear definition.

Originally posted by @phorward in #1109 (review)
@sveneberth sveneberth added Priority: Low This issue can be considered with enough idle time. refactoring Pull requests that refactor code but do not change its behavior. python Pull requests that update Python code labels Mar 19, 2024
@sveneberth sveneberth added this to the ViUR-core v4.0 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low This issue can be considered with enough idle time. python Pull requests that update Python code refactoring Pull requests that refactor code but do not change its behavior.
Projects
None yet
Milestone
ViUR-core v3.8
Development

No branches or pull requests
2 participants
@sveneberth @phorward