Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement type validation in conf #1110

Open
phorward opened this issue Mar 15, 2024 · 0 comments
Open

Implement type validation in conf #1110

phorward opened this issue Mar 15, 2024 · 0 comments
Assignees
Labels
feature New feature or request performance This issue or pull request enhances or criticizes the performance.

Comments

@phorward
Copy link
Member

phorward commented Mar 15, 2024

In the longer term, we could also look to validate the values in setattr against the type hints.

Originally posted by @sveneberth in #1106 (comment)


There're already some checks that can be improved

I think this check could be moved to a better place where it is not called on every request. But okay for main. On develop, we can validate it in the config object.

Originally posted by @sveneberth in #1106 (comment)

@phorward phorward added this to the ViUR-core v3.6 milestone Mar 15, 2024
@phorward phorward added the performance This issue or pull request enhances or criticizes the performance. label Mar 15, 2024
@sveneberth sveneberth changed the title Implement conf["viur.paramFilterFunction"] more efficiently Implement type validation in conf Oct 23, 2024
@sveneberth sveneberth added the feature New feature or request label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request performance This issue or pull request enhances or criticizes the performance.
Projects
None yet
Development

No branches or pull requests

2 participants