Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it subproject friendly #230

Closed
esodan opened this issue Jan 9, 2022 · 2 comments
Closed

Make it subproject friendly #230

esodan opened this issue Jan 9, 2022 · 2 comments
Labels
code Issues affecting code quality and coverage

Comments

@esodan
Copy link
Contributor

esodan commented Jan 9, 2022

I would like to add VLS to GVLS test suite. GVls has a LSP Vala Client, so add an independent server is good test scenario.

Also I would like to use VLS as a Meson subproject, in order to do so I need you set to a variable the VLS executable.

vls = executable(...)

So GVls can execute VLS server and test it and use it as a Meson subproject.

This could also help to fix #227

@Prince781 Prince781 added meta Meta-level issues pertaining to this project code Issues affecting code quality and coverage and removed meta Meta-level issues pertaining to this project labels Jan 9, 2022
@Prince781
Copy link
Member

I think you'd have a better idea of what's needed for your use case than I do. I have a rough idea, but I think a PR from you would be more fruitful.

@esodan
Copy link
Contributor Author

esodan commented Jan 12, 2022

Done. upstream.

@esodan esodan closed this as completed Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Issues affecting code quality and coverage
Projects
None yet
Development

No branches or pull requests

2 participants