Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow skip on BuildError #31

Open
ransford opened this issue Aug 3, 2014 · 1 comment
Open

allow skip on BuildError #31

ransford opened this issue Aug 3, 2014 · 1 comment
Labels

Comments

@ransford
Copy link
Contributor

ransford commented Aug 3, 2014

Some values of loop perforation knobs cause the version of llc shipped with LLVM 3.2 to crash during isel ( 👍 ) on the MSP430 benchmarks. accept.core.build() quite sensibly raises a BuildError, but this causes accept run to bail. I'd argue that that result should be simply triaged as bad instead; the parameter-space exploration could continue.

It's not just this test case. I can imagine BuildErrors resulting from knob adjustments in other scenarios too, for example when relaxing something causes an aggressive analysis to decide there's an error.

@sampsyo
Copy link
Member

sampsyo commented Aug 3, 2014

Awesome, very awesome, thanks LLVM isel. Yes, let's suppress these for the sake of fault isolation.

I'm not sure whether it should be allowed for optimizations to fail when they're applied. It seems like they should do all their work up front (at analysis time) to determine whether it's safe to apply. This avoids bothering the autotuner with stuff that won't work out anyway. But it could be infeasible to do that for some optimizations... worth continuing to think about.

@sampsyo sampsyo added the driver label Aug 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants