Value as string converted into number

[olivbau]

Environment

nodejs
v1.8.0

Reproduction

const storage = createStorage();
await storage.setItem('123', '456')
const item = await storage.getItem('123');
console.log(item, typeof item)
// 456, number
// instead of: "456", string

Describe the bug

Storage convert string into number for no reason

EDIT:After investigation, it's probably due to destr
https://github.com/unjs/unstorage/blob/main/src/storage.ts#L173C9-L173C21

Additional context

No response

Logs

No response

[pi0]

Hi. Yes this is the default behavior as we try to keep native JSON types. I think we might support an option to opt-out from this feature but in the meantime you can use setItem(key, '"123")

[molvqingtai]

unstorage/src/_utils.ts

Line 35 in 95da940

return String(value);

The error is caused by the String(value) method in stringify. Should the behavior of stringify be consistent with JSON.stringify?

String():

String('1') // '1'
String(true) // 'true'
String(null) // 'null'
String('[]') // '[]'

JSON.stringify & JSON.parse :

JSON.stringify('1') // '"1"'
JSON.stringify(true) // 'true'
JSON.stringify(null) // 'null'
JSON.stringify('[]') // '"[]"'


JSON.parse(JSON.stringify('1')) //  '1'
JSON.parse(JSON.stringify(true)) // true
JSON.parse(JSON.stringify(null)) // null
JSON.parse(JSON.stringify('[]')) // '[]'

idb-keyval:

import { set, get } from 'idb-keyval'

await set('foo', '[]')
await get('foo') // '[]'

await set('bar', null)
await get('bar') // null

Inconsistent behavior of String() and JSON.stringify() will lead to confusion, which makes it impossible to migrate directly from idb-keyval to unstorage

I use jsonr to store the compressed json into storage. Because the value obtained by getItem is not the value originally stored, an error is reported.

@pi0

[molvqingtai]

I tried using JSON.stringify to handle the string value, but this broke too many test cases