Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checksum validation in datetime time zone names #6063

Open
sffc opened this issue Feb 3, 2025 · 0 comments
Open

Fix checksum validation in datetime time zone names #6063

sffc opened this issue Feb 3, 2025 · 0 comments
Labels
C-datetime Component: datetime, calendars, time zones T-bug Type: Bad behavior, security, privacy

Comments

@sffc
Copy link
Member

sffc commented Feb 3, 2025

Currently we check the checksum only on the first load of a time zone name payload. However, we should retain the checksum in case we need to do further loads, at least the one in mz_periods.

This bug can probably be triggered by making a formatter with the pattern "ZZZZ VVVV" (two different time zone fields that both require loading metazone periods).

Also, consider optimizing BlobSchema::get_checksum to use the probe function. We shouldn't need to binary-search the ZeroTrie.

#6046

@sffc sffc added C-datetime Component: datetime, calendars, time zones T-bug Type: Bad behavior, security, privacy labels Feb 3, 2025
@sffc sffc added this to the ICU4X 2.0 Stretch ⟨P2⟩ milestone Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-datetime Component: datetime, calendars, time zones T-bug Type: Bad behavior, security, privacy
Projects
None yet
Development

No branches or pull requests

1 participant