-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the jupyter notebook example to use current version #19
Comments
Spent some time debugging this issue, and here are a few findings:
I tested vanilla THREE setup with OrbitControls and make it work independently in a notebook - happy to add that if there's interest. For now, this is just stuck on the module incompatibility, and I can't seem to find any obvious workarounds. Creating an old-style bundle just for this use-case is probably unnecessary, so not quite sure where to go from here @sritchie / @ChristopherChudzicki |
Another related update - when I tried to use the library in another AMD/require environment (ObservableHQ), the UMD bundle isn't looking usable. Public notebook here has more details - re-capturing the summary:
For now, added older examples in this collection using similar structure from the Jupyter notebook |
Thank you for digging into these issues! I am swamped with some work that uses this code, so I won't have time to get to these for a while. Hopefully that is not a blocker on anything you're doing. I think it's important to get this fixed and to get that readback example working, eventually, so thank you again. |
Happy to help! Having a cleaner webpack bundle would help but this isn't blocking my downstream experiments as I'm using (ESM) source directly. I will definitely raise issues/ pull requests for any urgent blockers. Thanks |
See discussion in #17
The text was updated successfully, but these errors were encountered: