Link images in slideshow #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ansition. otherwise, image links on second and third slide will be overlaid with image links from the first slide.
|
I'm wary of introducing a feature knowing this particular bug is there. Let's talk a bit about it in Slack. No rush on this. Thanks for doing it! |
sounds good, i'm not too excited about the proposed solution here either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12
please note that this is kinda hinky.
if you remain moused-over any slides the browser will hold on to the images links from the first slide that you moused-over initially.
you'll have to mouse-out, then mouse back over in order for the browser to render the correct linkage.
best i can do for now, lmk if you have a better, easy solution that won't require rewriting the slideshow altogether.