Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide multi-arch docker image #57

Closed
darkweaver87 opened this issue Mar 22, 2024 · 4 comments
Closed

Provide multi-arch docker image #57

darkweaver87 opened this issue Mar 22, 2024 · 4 comments

Comments

@darkweaver87
Copy link
Contributor

darkweaver87 commented Mar 22, 2024

Description

Scraper is currently not working on ARM architecture for instance.

Steps to reproduce

Run it on an ARM machine, you will get an exec format error.

Expected Behavior

Run it as it runs on X86.

Actual Behavior

Doesn't run.
I'll be happy to help on that topic but I didn't find any CI job I can modify which actually produces the docker image ...
I understand that selenium can't be installed on ARM but do you think to some alternatives ?

Metadata

Typesense Version: 0.25.2

OS: any OS running containerd/dockerd

@jasonbosco
Copy link
Member

A PR to make it multi-arch would be great.

I follow the steps in this section of the README to release a new version: https://github.com/typesense/typesense-docsearch-scraper?tab=readme-ov-file#releasing-a-new-version

@darkweaver87
Copy link
Contributor Author

OK thanks, I wanted to check if there were any kind of CI job for releasing. I'll open a PR then :-)

@immanuelfodor
Copy link

Fixed by #58

@jasonbosco
Copy link
Member

Thank you again @darkweaver87!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants