Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Mandelbrot app #2841

Closed
wants to merge 3 commits into from
Closed

Added Mandelbrot app #2841

wants to merge 3 commits into from

Conversation

scriptorum
Copy link

This app has numerous time checks to prevent the 30 second timeout and improve quality within the time allotted. However, after working on this for weeks, I find that pixlet check has a one second time out! Despite likely failing that automated check, I hope you'll accept it anyway, as it looks pretty cool on my Tidbyt. :)

I have read the CLA Document and I hereby sign the CLA

@scriptorum scriptorum requested a review from matslina as a code owner October 29, 2024 19:49
@tidbyt
Copy link

tidbyt bot commented Oct 29, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
🟡 App Dir File 'apps/mandelbrot/screenshots/m1.gif' is in apps/mandelbrot/screenshots
🟡 Modules Usage of random.star requires review
Original Author The original author matches the PR author

@scriptorum
Copy link
Author

@matslina Is the 1 second check mandatory?

@scriptorum
Copy link
Author

@matslina Is the 1 second check mandatory?

I guess that's a yes?

@stale stale bot added the wontfix label Jan 9, 2025
Copy link

stale bot commented Jan 11, 2025

We're automatically closing this issue because it hasn't had any activity in 30 days. If that seems like a mistake, please feel free to re-open. Thanks!

@stale stale bot closed this Jan 11, 2025
@tidbyt tidbyt locked as resolved and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant