Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for timestamp function #206

Closed
fpetkovski opened this issue Mar 7, 2023 · 3 comments · May be fixed by #257
Closed

Add support for timestamp function #206

fpetkovski opened this issue Mar 7, 2023 · 3 comments · May be fixed by #257
Assignees
@nishchay-veer
Labels
good first issue Good for newcomers

Comments

@fpetkovski
Copy link
Collaborator

The timestamp function is currently broken and we've decided to revert it in #204.

The correct way to implement it is to return each sample's timestamp instead of the step timestamp. This will make sure that samples returned due to the engine lookback have their original timestamp in the output.

One way to do it is to detect the presence of a the timestamp function in a query (maybe through an optimizer), and push it down into the vector selector. The selector will then store timestamps directly into the values of output vectors.
@fpetkovski fpetkovski mentioned this issue Mar 7, 2023
Merged
@fpetkovski fpetkovski added the good first issue Good for newcomers label Apr 1, 2023
@nishchay-veer
Copy link
Contributor

Hey @fpetkovski I've a good understanding of tests in GO . Can you please assign this to me so I could work on this ?

@nishchay-veer nishchay-veer mentioned this issue May 11, 2023
Open
@nishchay-veer
Copy link
Contributor

Could you provide guidance on the modifications I should make?

@yeya24 yeya24 mentioned this issue Jul 29, 2023
Closed
@fpetkovski
Copy link
Collaborator Author

Closed by #366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nishchay-veer nishchay-veer

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add comprehensive test and support for timestamp function nishchay-veer/promql-engine
2 participants
@fpetkovski @nishchay-veer