Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cgroup): add support for configuring Linux cgroup mode in autopilot clusters #2282

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(cgroup): add support for configuring Linux cgroup mode in autopilot clusters #2282

wants to merge 5 commits into from

Conversation

Ameausoone
Copy link

@Ameausoone Ameausoone commented Feb 13, 2025 •
edited
Loading

This update introduces a new linux_cgroup_mode variable to specify the cgroup hierarchy mode for autopilot Kubernetes nodes. Supported values include CGROUP_MODE_UNSPECIFIED, CGROUP_MODE_V1, and CGROUP_MODE_V2. Adjusted cluster configurations to include dynamic management of the Linux node configuration based on this variable.

  • make build

Closes #2264

@Ameausoone Ameausoone requested review from apeabody, ericyz and a team as code owners February 13, 2025 16:26
@Ameausoone Ameausoone mentioned this pull request Feb 13, 2025
Open
@Ameausoone
feat(cgroup): add support for configuring Linux cgroup mode in autopi…
4167797 
…lot clusters

This update introduces a new `linux_cgroup_mode` variable to specify the cgroup hierarchy mode for autopilot Kubernetes nodes. Supported values include `CGROUP_MODE_UNSPECIFIED`, `CGROUP_MODE_V1`, and `CGROUP_MODE_V2`. Adjusted cluster configurations to include dynamic management of the Linux node configuration based on this variable.
@Ameausoone
chore: rename variable to node_pools_cgroup_mode
b0e4363
@Ameausoone
refactor: reformat cgroup mode validation for improved readability
be28848 
Updated the condition block in `node_pools_cgroup_mode` validation across multiple variables files to use a more readable multi-line format.
@Ameausoone
refactor: replace conditional operator with coalesce in variables.tf
4305a5a 
Updated variable validation logic to use the `coalesce` function instead of conditional operators for `node_pools_cgroup_mode`, improving readability and consistency across modules.
@Ameausoone
Revert "`refactor: replace conditional operator with coalesce in vari…
efe18f2 
…ables.tf`"

This reverts commit 7434326.
@Ameausoone
Copy link
Author 

      ~ node_pool_auto_config {
            # (1 unchanged attribute hidden)

          ~ linux_node_config {
              ~ cgroup_mode = "CGROUP_MODE_V2" -> "CGROUP_MODE_V1"
            }

          + network_tags {}
        }

....
│ Error: googleapi: Error 400: Setting cgroup_mode to v1 is not allowed for clusters created with version 1.31.4-gke.1372000.
│

I think this issue will be quickly deprecated

@apeabody
Copy link
Collaborator 

      ~ node_pool_auto_config {
            # (1 unchanged attribute hidden)

          ~ linux_node_config {
              ~ cgroup_mode = "CGROUP_MODE_V2" -> "CGROUP_MODE_V1"
            }

          + network_tags {}
        }

....
│ Error: googleapi: Error 400: Setting cgroup_mode to v1 is not allowed for clusters created with version 1.31.4-gke.1372000.
│

I think this issue will be quickly deprecated

Yes, here is the plan for Standard: https://cloud.google.com/kubernetes-engine/docs/how-to/migrate-cgroupv2#transition-plan I've requested additional clarification for Autopilot.

Ref:
https://cloud.google.com/kubernetes-engine/docs/release-schedule#schedule-for-release-channels

@apeabody
Copy link
Collaborator

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody left review comments

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No option to set cgroup under beta-autopilot-private-cluster
2 participants
@Ameausoone @apeabody