Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No option to set cgroup under beta-autopilot-private-cluster #2264

Open
scipe opened this issue Feb 5, 2025 · 3 comments · May be fixed by #2282
Open

No option to set cgroup under beta-autopilot-private-cluster #2264

scipe opened this issue Feb 5, 2025 · 3 comments · May be fixed by #2282
Labels
enhancement New feature or request good first issue Good for newcomers triaged Scoped and ready for work

Comments

@scipe
Copy link

scipe commented Feb 5, 2025

TL;DR

Module beta-autopilot-private-cluster has no option to set node_pool_auto_config.linux_node_config.cgroup_mode parameter.

Expected behavior

End-user should able to set cgroup v2 via that module.

Observed behavior

No response

Terraform Configuration

any

Terraform Version

any

Terraform Provider Versions

any

Additional information

I might miss something, but after careful checking the source for that module I didn't found any way.

@scipe scipe added the bug Something isn't working label Feb 5, 2025
@apeabody
Copy link
Collaborator

apeabody commented Feb 6, 2025

Hi @scipe - We would welcome a pull request to add this capability. Here is the general area in the template:https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/main/autogen/main/cluster.tf.tmpl#L281. Cheers!

@apeabody apeabody added enhancement New feature or request good first issue Good for newcomers triaged Scoped and ready for work and removed bug Something isn't working labels Feb 6, 2025
@scipe
Copy link
Author

scipe commented Feb 9, 2025

@apeabody ok thank you. Gonna create PR soon.

@scipe
Copy link
Author

scipe commented Feb 9, 2025

Hi @apeabody. Here is a PR: #2273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers triaged Scoped and ready for work
Projects
None yet
2 participants