Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell layer shell buffer doesn't obey location property #8381

Closed
MRFaria opened this issue Feb 16, 2017 · 4 comments
Closed

Shell layer shell buffer doesn't obey location property #8381

MRFaria opened this issue Feb 16, 2017 · 4 comments

Comments

@MRFaria
Copy link

MRFaria commented Feb 16, 2017

Description:
Shell layer shell buffer doesn't obey location property when the default shell is 'shell

Reproduction guide:

  • Start Emacs
  • run <SPC '>

Observed behaviour:
Starting the shell buffer by pressin <SPC '> brings it up at the top of the frame, or in an already created split window. Not the bottom as requested by setting 'shell-default-position to 'bottom

Expected behaviour:
Shell buffer should appear at the bottom. Note, this works if I set 'shell-default-shell to 'ansi-term; but I prefer using 'shell.

System Info:

  • OS: gnu/linux
  • Emacs: 25.1.1
  • Spacemacs: 0.200.7
  • Spacemacs branch: nil (rev. 57e653a)
  • Graphic display: t
  • Distribution: spacemacs
  • Editing style: vim
  • Completion: helm
  • Layers:
(python ibuffer helm auto-completion better-defaults emacs-lisp c-c++ semantic d gnus
        (gtags :variables gtags-enable-by-default t)
        (shell :variables shell-default-shell 'shell shell-default-position 'bottom)
        (org))
  • System configuration features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GCONF NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK2 X11
@MRFaria
Copy link
Author

MRFaria commented Feb 16, 2017

C-c C-c to submit the issue didn't work for me from emacs, so I just copied and pasted the text in the buffer

@bmag
Copy link
Contributor

bmag commented Feb 19, 2017

Sounds like either #7691 (upstream bug in shell-pop, reproducible in stock Emacs) or #8171 (some clash between window-purpose and shell-pop). @MRFaria can you verify that your problem either reproduces with stock Emacs, or disappears if you disable purpose-mode?

@MRFaria
Copy link
Author

MRFaria commented Feb 19, 2017

Disabling purpose-mode doesn't do anything, but it looks like the issue still happens in stock emacs.
I installed shell-pop through marmalade:
M-: (add-to-list 'package-archives '("marmalade" . "http://marmalade-repo.org/packages/"))
M-x package-refresh-contents
M-x package-install [RET] shell-pop

Then I customised shell-pop to appear on the bottom:
M-: (require 'shell-pop)
M-x customize-set-variable [RET] shell-pop-window-position [RET] bottom

Then, when running shell-pop it appears on the top of the frame anyway

@bmag
Copy link
Contributor

bmag commented Feb 19, 2017

@MRFaria thanks, I'm closing this as a duplicate of #7691. We're waiting for the issue to be resolved upstream. Judging from the activity in https://github.com/kyagi/shell-pop-el/commits/master, it seems it won't be fixed unless someone submits a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants