Missing test case for no :path header

[ThetaSinner]

There is a test case for a :path with an invalid value, but no test for a missing :path header

[madgnome]

It seems that this test

h2spec/http2/8_1_2_3_request_pseudo_header_fields.go

Line 214 in 5de785c

tg.AddTestCase(&spec.TestCase{

is a duplicate of

h2spec/http2/8_1_2_3_request_pseudo_header_fields.go

Line 154 in 5de785c

tg.AddTestCase(&spec.TestCase{

and should have been the test for missing :path

I will raise a PR.

[madgnome]

There's already a test for missing :path

tg.AddTestCase(&spec.TestCase{
		Desc:        "Sends a HEADERS frame that omits \":path\" pseudo-header field",
		Requirement: "The endpoint MUST respond with a stream error of type PROTOCOL_ERROR.",
		Run: func(c *config.Config, conn *spec.Conn) error {
			var streamID uint32 = 1

			err := conn.Handshake()
			if err != nil {
				return err
			}

			headers := spec.CommonHeaders(c)
			headers = []hpack.HeaderField{
				headers[0], // :method
				headers[1], // :scheme
				headers[3], // :authority
			}

			hp := http2.HeadersFrameParam{
				StreamID:      streamID,
				EndStream:     true,
				EndHeaders:    true,
				BlockFragment: conn.EncodeHeaders(headers),
			}

			conn.WriteHeaders(hp)

			return spec.VerifyStreamError(conn, http2.ErrCodeProtocol)
		},
	})