Missing tests

[CrowdHailer]

I have a few extra test cases in my servers test suite that I think could be moved to h2spec. I just wanted to check I hadn't missed them before trying to open a PR. (I've never written any go so don't want to waste my time if these tests are already implemented)

possible extra tests

• http/3.5

  • Send a valid http2 preface but then follow it with not a settings frame. expect GoAway with protocol error
  • A test that expects an ack for the clients initial settings from the server.

• Can there be a test that makes 1+ valid requests then behaves incorrectly and we expect the last stream id to be equal to the last request processed?

[summerwind]

Hi, thank you for your suggestion.
It is good to add the tests you proposed test as a generic test case.

h2spec has three types of test case, http2, hpack, and generic. In the test case of http2 and hpack, the test of what is clearly required in the specification is implemented. generic test cases are implemented with tests to verify common HTTP/2 implementations.

The details of the generic test case can be confirmed below:
https://github.com/summerwind/h2spec/tree/master/generic

[CrowdHailer]

Thanks,

I think there should also be a test that checks that sending a continuation with a different stream_id, to the original headers frame, is a protocol_error