Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

AssertJ module #83

Closed
aahlenst opened this issue Nov 10, 2013 · 8 comments
Closed

AssertJ module #83

aahlenst opened this issue Nov 10, 2013 · 8 comments

Comments

@aahlenst
Copy link
Contributor

Have you thought about supporting AssertJ instead of/in addition to fest-assert-2.x? fest-assert-2.x is dormant and if it comes to life again chances are it is going to be less useful (there are plans to remove a lot of assertions, see alexruiz/fest-assert-2.x#159 and https://github.com/joel-costigliola/assertj-core#why-have-we-forked-fest-assert). I'd be willing to provide a patch, but it would be a breaking change (packages have to be renamed) and eventually involve renaming the project to assertj-android.

@imminent
Copy link

Related, the FEST link in the README doesn't point to a page that exists still.

@f2prateek
Copy link
Contributor

@aahlenst I would suggest that an assertj-android project shoudl exist as a different entity, completely independent of fest-android.

@aahlenst
Copy link
Contributor Author

@f2prateek I agree. Maybe even under the umbrella of the AssertJ project.

But before taking any actions I like to hear from @JakeWharton whether he's ok with it or if he/Square has other plans. Creating a fork is easy, maintaing it in the long term not so much.

@JakeWharton
Copy link
Collaborator

Can we wait until after the new year to decide? I haven't taken a long enough look to have a strong opinion yet.

@avh4
Copy link

avh4 commented Feb 8, 2014

I've created https://github.com/avh4/assertj-android for my own personal use, and plan on trying to keep it up-to-date on a ~monthly basis for now until there's an official decision on what to do with this. FEST no longer seems to be being maintained, and their website no longer exists, so I've been switching all my projects to AssertJ.

@aahlenst
Copy link
Contributor Author

aahlenst commented Mar 2, 2014

@JakeWharton Have you made up your mind yet? Would you approve a fork?

@imminent
Copy link

imminent commented Mar 2, 2014

Forks are naturally accepted. Do you mean to merge assn AssertJ back into
the main library?
On Mar 2, 2014 7:11 AM, "Andreas Ahlenstorf" [email protected]
wrote:

@JakeWharton https://github.com/JakeWharton Have you made up your mind
yet? Would you approve a fork?

Reply to this email directly or view it on GitHubhttps://github.com//issues/83#issuecomment-36456422
.

@JakeWharton
Copy link
Collaborator

This is done on master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants