Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SendIt] Should remove HTML comment #1209

Open
gam6itko opened this issue Jan 27, 2025 · 0 comments
Open

[SendIt] Should remove HTML comment #1209

gam6itko opened this issue Jan 27, 2025 · 0 comments
Labels

Comments

@gam6itko
Copy link
Contributor

gam6itko commented Jan 27, 2025

Description

HTML comments present in final Mail but it shouldn't.

How To Reproduce

Here my hello.dark.php template

<extends:sendit:builder subject="{{ $subject }}"/>

<use:bundle path="sendit:bundle"/>

<block:html>
<!--    <h1>commented</h1>-->

    <h1>Hello from Producer!</h1>

</block:html>

<block:text>
Hello from Producer!
</block:text>

In buggregator I see this

Image

I think SendIt should cut off HTML comments.

Here candbox project to reproduce gam6itko/spiral-app-sandbox@90bd90e

Additional Info

Q A
Framework Version 3.14.10
PHP version 8.3
Operating system Linux
@gam6itko gam6itko added the Bug label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant