-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Takes a significant amount of time check if URL is reachable #7
Comments
Hey, @souvikinator! Can you confirm to me that you are talking about the Line 109 in 0e62517
I perform a few tests and this operation takes on average 3μs to execute. Are you sure this operation is the one that is taking too long to execute? I did try a few alternatives (other methods and using a TCP dial directly to the address), but the Head execution seems to me to be the way to go. Maybe we could think into another strategy for parsing the url, it could take a few milliseconds from the runtime |
Hey, @caioeverest yes I'm talking about |
No problem at all. I'm going to make a few more tests to try to see if I found where it is getting slow. Can you share with me the host that you used in your testings and notice this behavior? |
sure, there you go: However, I encountered another issue as well. When I query using |
I opened a pull request (pr-#8) that will handle this kind of error and retry the request when it is necessary. Also, I took the liberty to add a time mark for us to know how long the process takes and a more fit transport configuration that helps a little bit in performance. |
Improve processing speeds and error handling (Issue #7)
Before performing any fuzzing queries, gofuzz checks whether URL is reachable? Current state: It takes a significant amount of time to perform this function.
The text was updated successfully, but these errors were encountered: