Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#77] ♻️ : 리펙토링 및 이슈 수정 #77

Open
2 tasks done
jaewoong2 opened this issue Nov 3, 2022 · 0 comments
Open
2 tasks done

[#77] ♻️ : 리펙토링 및 이슈 수정 #77

jaewoong2 opened this issue Nov 3, 2022 · 0 comments
Assignees
@jaewoong2
Labels
enhancement New feature or request

Comments

@jaewoong2
Copy link
Member

해야 할 일

  • 토큰이 없어도 [Get] User 요청을 하는 것 수정 (이유에 해당 되는것 모두 수정)
    • 이유1: localstorage 를 캐싱 하고 있는데, 이거를 계속 업데이트를 안함
    • 이유2: Boolean(value) && options?.enabled 가 의도한 대로 작동하지 않음
      • 이유: undefined 가 return 되는데, react-query 의 enabled 옵션은 undefined 면 true 로서 기능 하기 때문에
      • value ? options?.enabled : false 로 변경
  • toast 리팩토링
@jaewoong2 jaewoong2 added the enhancement New feature or request label Nov 3, 2022
@jaewoong2 jaewoong2 self-assigned this Nov 3, 2022
jaewoong2 added a commit that referenced this issue Nov 3, 2022
@jaewoong2
🐛 query enabled 옵션 수정 (#77)
59470b0
jaewoong2 added a commit that referenced this issue Nov 3, 2022
@jaewoong2
♻️ 리팩토링 (#77-2)
6ad7243
@jaewoong2 jaewoong2 mentioned this issue Nov 3, 2022
Merged
jaewoong2 added a commit that referenced this issue Nov 3, 2022
@jaewoong2
Merge pull request #78 from soma-dalda/feat/#77
6ee26bb 
[#77] ♻️ , 🐛 : 이슈 수정 및 리팩토링
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaewoong2 jaewoong2

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaewoong2