Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors in stop events #2

Open
davydog187 opened this issue Nov 6, 2020 · 0 comments
Open

Handle errors in stop events #2

davydog187 opened this issue Nov 6, 2020 · 0 comments
Labels
good first issue Good for newcomers

Comments

@davydog187
Copy link
Collaborator

commanded/commanded#414 closer aligned telemetry events to the conventions defined in :telemetry.span/3. Now we should expect some stop events to receive errors. In that case we should set error to true as an attribute, and attach the error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davydog187