We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spinning off from #314:
With the complexities involved with parsing colors, there are concerned about regressing the time it takes to parse them.
Per @emilio:
But it should be rather trivial to add a few benchmarks for color parsing in src/tests.rs like we have for data: uris etc?
src/tests.rs
data:
We should look into that.
The text was updated successfully, but these errors were encountered:
Hi :) Do you think this issue could be a good candidate to start contribute? If so, may I take this one?
Sorry, something went wrong.
Hey, sure thing, go ahead!
It has been a long time... If I'm not mistaken, there is no benchmarking at all in GH workflow, despite bench feature marks in the test code.
bench
I'm fully rely on the docs: https://doc.rust-lang.org/unstable-book/library-features/test.html
So, part of this issue solve will be adding some custom workflow?
I don't think we necessarily need a custom workflow, just something that can be benchmarked easily locally.
Of course the more we can automate after that the better, but that's not a strict requirement imo.
No branches or pull requests
Spinning off from #314:
With the complexities involved with parsing colors, there are concerned about regressing the time it takes to parse them.
Per @emilio:
We should look into that.
The text was updated successfully, but these errors were encountered: