Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port xplr.fn.builtin.try_complete_path over to Rust #643

Open
sayanarijit opened this issue Jul 8, 2023 · 0 comments
Open

Port xplr.fn.builtin.try_complete_path over to Rust #643

sayanarijit opened this issue Jul 8, 2023 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@sayanarijit
Copy link
Owner

sayanarijit commented Jul 8, 2023

The following function should be gone:

xplr/src/init.lua

Line 2858 in f3a2d51

xplr.fn.builtin.try_complete_path = function(m)

Instead, we should have something like:

    /// Try to complete the text in the input buffer at the cursor position
    /// using the given completion method(s).
    ///
    /// Type: { TryComplete = { command = bool, path = bool, options = ["strings"] } }
    ///
    /// Example:
    ///
    /// - Lua: `{ TryComplete = { command = true, path = true, options = { "foo", "bar" } } }`
    /// - YAML: `TryComplete: { command: true, path: true, options: [foo, bar] }`
    TryComplete(Completion),

See messages implementations.

Subtask of #641

@sayanarijit sayanarijit added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jul 8, 2023
@sayanarijit sayanarijit changed the title Port xplr.fn.builtin.default.try_complete_path over to Rust Port xplr.fn.builtin.try_complete_path over to Rust Jul 8, 2023
@sayanarijit sayanarijit removed the good first issue Good for newcomers label Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant