Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement proxy protocol #4186

Open
vitoyucepi opened this issue Oct 22, 2024 · 2 comments
Open

Implement proxy protocol #4186

vitoyucepi opened this issue Oct 22, 2024 · 2 comments

Comments

@vitoyucepi
Copy link
Collaborator

Description

I'd like to see support for the proxy protocol in liquidsoap for various inputs and harbors. It preserves client IP when working behind the reverse proxy.
It's possible to use the http headers x-forwarded-for and x-real-ip for HTTP, but for TCP streams, like Icy, it's never been an option.

Preferable solution

Add an option to switch the port into proxy mode.

Alternative solutions

No response

Additional context

I don't know the origin of the proxy protocol, but it seems the haproxy developed it.

The promotional post in the haproxy blog about it is available here: https://www.haproxy.com/blog/use-the-proxy-protocol-to-preserve-a-clients-ip-address.
The specification can be found here: https://github.com/haproxy/haproxy/blob/master/doc/proxy-protocol.txt.

@toots
Copy link
Member

toots commented Oct 23, 2024

Thanks! Do you mean that you would like liquidsoap to be able to act as a proxy?

@vitoyucepi
Copy link
Collaborator Author

liquidsoap to be able to act as a proxy?

I'd like to put it behind haproxy, nginx, or another reverse proxy server that will terminate the encryption but still preserve the external IP address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants