Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider publishing generated files #252

Open
TomaSajt opened this issue Oct 15, 2024 · 0 comments
Open

Consider publishing generated files #252

TomaSajt opened this issue Oct 15, 2024 · 0 comments

Comments

@TomaSajt
Copy link

TomaSajt commented Oct 15, 2024

I'm a package maintainer on Nixpkgs and I'm in the process of adding this package to our package collection.

The issue is that our build system needs to have a stable hash for files fetched from the internet, but the code-generation doesn't look to be reproducible, e.g. the localisation data may change.

AFAICT the graphql schema and tolgee localisation data is currently fetched from api.ficsit.app. Unfortunately, this means that fetching the data will always yield the latest version of the translations/graphql stuff.

Knowing this, I would ask that you consider also publishing the contents of frontend/src/lib/generated so that we can build the application in a reproducible way.

Another solution would be to allow fetching a specific revision of the data from the API, however that sounds more difficult than the method above.

Related PR: NixOS/nixpkgs#348137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant