New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate the use of expression walkers #13

Open

whart222 opened this issue Jan 2, 2023 · 0 comments

Collaborator

whart222 commented Jan 2, 2023

The mutable_values() function is a subset of the functionality provided by find_vars_and_params(). Do we need both?

The find_variables() function merely calls find_vars_and_params(). Is there enough efficiency gain to motivate a separate walker?

whart222 added a commit that referenced this issue


          Merge pull request #13 from michaelbynum/build_tests

1182f1c

fix build of tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment