Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to update the thanks page? #70

Open
mahmoud-moursy opened this issue Sep 20, 2024 · 3 comments
Open

Is it possible to update the thanks page? #70

mahmoud-moursy opened this issue Sep 20, 2024 · 3 comments

Comments

@mahmoud-moursy
Copy link

I have contributed to Rust's standard library and documentation if I recall correctly in the past, but since then I have changed my Github username, so I no longer show up on the "thanks" page for my original contributions.

I was T-O-R-U-S beforehand.

@Noratrieb
Copy link
Member

@mahmoud-moursy this is controlled via the .mailmap in the rust-lang/rust repository. it looks at the git authorship information (the username there and the email there). the GitHub username doesn't matter, but if you contribute from multiple email addresses or names you need to add the entries in the mailmap to unify them all

@mahmoud-moursy
Copy link
Author

Is there a formal process for this, or do I just open a PR?

@Noratrieb
Copy link
Member

just open a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants