Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 TMVA test requires BLAS library but run even when it was not found. #16720

Open
pcanal opened this issue Oct 19, 2024 · 4 comments · May be fixed by #16722
Open

4 TMVA test requires BLAS library but run even when it was not found. #16720

pcanal opened this issue Oct 19, 2024 · 4 comments · May be fixed by #16722
Assignees
Labels

Comments

@pcanal
Copy link
Member

pcanal commented Oct 19, 2024

See #16553

The following 3 tests fails consistently with missing BLAS symbols

984:tutorial-tmva-TMVA_SOFIE_GNN_Application
988:tutorial-tmva-TMVA_SOFIE_RDataFrame
990:tutorial-tmva-TMVA_SOFIE_RSofieReader
353-gtest-tmva-pymva-TestRModelParserKeras
@dpiparo
Copy link
Member

dpiparo commented Oct 19, 2024

Unassigning and reassigning to @lmoneta

@dpiparo
Copy link
Member

dpiparo commented Oct 19, 2024

I am not sure I understand the problem.
If I look at 984:tutorial-tmva-TMVA_SOFIE_GNN_Application, the tests run fine in the CI for alma9: the reason for the failure could be due to the local setup.

As for

988:tutorial-tmva-TMVA_SOFIE_RDataFrame
990:tutorial-tmva-TMVA_SOFIE_RSofieReader
353-gtest-tmva-pymva-TestRModelParserKeras

If I understand correctly, they do not run in any of platforms of the CI since PyKeras is not available anywhere, e.g. in the requirements.txt file.

@dpiparo
Copy link
Member

dpiparo commented Oct 19, 2024

Apologies, I said something in error. All the aforementioned tests can be found successfully running in the CI. I think we are dealing with a difference between the container setup of the CI and the local setup.
@pcanal could you double-check your setup against the one of the container (see here and the requirements.txt file)?

@pcanal
Copy link
Member Author

pcanal commented Oct 20, 2024

Yes, it is clearly a difference is setup. In the failing one the BLAS library is not installed (or not found) and the real problem is that this result in a very obscure and hard to understand failure:

IncrementalExecutor::executeFunction: symbol 'saxpy_' unresolved while linking [cling interface function]!
IncrementalExecutor::executeFunction: symbol 'sgemm_' unresolved while linking [cling interface function]!

Instead we should either

  • fail to configure if BLAS is missing
    or
  • disable the components that require BLAS when configuring whe BLAS is missing
    or
  • disable the test that require BLAS when BLAS is not there.

and at the very least we should list somewhere (if not already done so, but I don't see it) that the BLAS library is required to successfully run the tests and some of the features.

dpiparo added a commit to dpiparo/root that referenced this issue Oct 21, 2024
@pcanal pcanal changed the title 3 TMVA test requires BLAS library but run even when it was not found. 4 TMVA test requires BLAS library but run even when it was not found. Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants