Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider return messages (and other fields?) as buffers #6

Open
davidben opened this issue Jun 28, 2013 · 1 comment
Open

Consider return messages (and other fields?) as buffers #6

davidben opened this issue Jun 28, 2013 · 1 comment

Comments

@davidben
Copy link

If you receive a zgram containing invalid UTF-8, we'll decode it into replacement characters. Roost will then encode as UTF-8 before storing into the database. Arguably we want to record the exact bytes in the database, even in the case of invalid UTF-8.

The one interesting thing that will change is that the roost REST API needs to change to pull messages as base64, and then the client decodes. This is somewhat of a pain, so let's only bother with all this if it comes up.

@davidben
Copy link
Author

I believe both DES and AES zcrypts already convert the ciphertexts into ASCII. And since messages cannot contain NULs, it is unlikely someone will care about arbitrary bytes in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant