Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of NUL bytes in strings #4

Open
davidben opened this issue May 8, 2013 · 0 comments
Open

Better handling of NUL bytes in strings #4

davidben opened this issue May 8, 2013 · 0 comments

Comments

@davidben
Copy link

davidben commented May 8, 2013

JavaScript strings (and C++ strings) can have NUL bytes. C strings can't. Currently we truncate silently, except for in the body, which should be fixed. Perhaps converting to replacement characters would be better.
davidben added a commit that referenced this issue May 8, 2013
@davidben
Truncate body components at NUL characters
7661b50 
Better to silently truncate (consistent with all of our other strings, sadly)
than to inject field separators. Issue #4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidben