diff --git a/core/lib/rom/plugins/relation/registry_reader.rb b/core/lib/rom/plugins/relation/registry_reader.rb index fec206387..4c3099a9c 100644 --- a/core/lib/rom/plugins/relation/registry_reader.rb +++ b/core/lib/rom/plugins/relation/registry_reader.rb @@ -14,9 +14,9 @@ class RegistryReader < ::Module EMPTY_REGISTRY = RelationRegistry.build(EMPTY_HASH).freeze # @api private - def initialize(klass:, relation_readers_module:) + def initialize(relation_readers:) super() - klass.include relation_readers_module + include relation_readers end # @api private diff --git a/core/lib/rom/setup/finalize/finalize_relations.rb b/core/lib/rom/setup/finalize/finalize_relations.rb index 056d4ab34..a02dec670 100644 --- a/core/lib/rom/setup/finalize/finalize_relations.rb +++ b/core/lib/rom/setup/finalize/finalize_relations.rb @@ -9,14 +9,12 @@ class Finalize class FinalizeRelations attr_reader :notifications - module BuildRelationReaders - def self.build(relations) - Module.new do - relations.each do |name| - define_method(name) do - __registry__[name] - end - end + class RelationReaders < ::Module + def initialize(relations) + super() + + relations.each do |name| + define_method(name) { __registry__[name] } end end end @@ -44,7 +42,7 @@ def initialize(gateways, relation_classes, notifications:, mappers: nil, plugins # rubocop:disable Metrics/AbcSize, Metrics/MethodLength def run! relation_registry = RelationRegistry.new do |registry, relations| - relation_readers_module = BuildRelationReaders.build(relation_names) + relation_readers = RelationReaders.new(relation_names) @relation_classes.each do |klass| unless klass.adapter raise MissingAdapterIdentifierError, @@ -58,7 +56,7 @@ def run! "Relation with name #{key.inspect} registered more than once" end - klass.use(:registry_reader, klass: klass, relation_readers_module: relation_readers_module) + klass.use(:registry_reader, relation_readers: relation_readers) notifications.trigger( 'configuration.relations.class.ready', diff --git a/repository/lib/rom/repository/class_interface.rb b/repository/lib/rom/repository/class_interface.rb index 1bf549348..6bc6a6877 100644 --- a/repository/lib/rom/repository/class_interface.rb +++ b/repository/lib/rom/repository/class_interface.rb @@ -60,7 +60,7 @@ def new(container = nil, **options) container ||= options.fetch(:container) unless relation_reader - relation_reader(RelationReader.new(self, container.relations.elements.keys)) + relation_reader(RelationReader.new(container.relations.elements.keys)) include(relation_reader) end diff --git a/repository/lib/rom/repository/relation_reader.rb b/repository/lib/rom/repository/relation_reader.rb index d365471ea..429e85bf5 100644 --- a/repository/lib/rom/repository/relation_reader.rb +++ b/repository/lib/rom/repository/relation_reader.rb @@ -7,40 +7,44 @@ class RelationReader < ::Module extend ::Dry::Core::ClassAttributes # @api private - attr_reader :klass - - # @api private - attr_reader :relations - defines :relation_readers + # @api private defines :mutex - mutex(Mutex.new) + mutex ::Mutex.new + # @api private defines :relation_cache - relation_cache(Concurrent::Hash.new) + relation_cache ::Concurrent::Hash.new + + # @api private + attr_reader :klass + + # @api private + attr_reader :relations module InstanceMethods # @api private - def set_relation(name) # rubocop:disable Naming/AccessorMethodName + def prepare_relation(name) container .relations[name] - .with(auto_struct: auto_struct, struct_namespace: struct_namespace) + .with( + auto_struct: auto_struct, + struct_namespace: struct_namespace + ) end def relation_reader(name, relation_cache) key = [name, auto_struct, struct_namespace] - relation_cache[key] ||= set_relation(name) + relation_cache[key] ||= prepare_relation(name) end end # @api private - def mutex - ROM::Repository::RelationReader.mutex - end + def mutex = self.class.mutex # @api private - def initialize(klass, relations) + def initialize(relations) super() @relations = relations mutex.synchronize do @@ -50,7 +54,7 @@ def initialize(klass, relations) ) end end - klass.include self.class.relation_readers + include self.class.relation_readers end # @api private diff --git a/repository/lib/rom/repository/root.rb b/repository/lib/rom/repository/root.rb index be0c891be..17d0a57dc 100644 --- a/repository/lib/rom/repository/root.rb +++ b/repository/lib/rom/repository/root.rb @@ -58,7 +58,7 @@ def self.inherited(klass) # @see Repository#initialize def initialize(*, **) super - @root = set_relation(self.class.root) + @root = prepare_relation(self.class.root) end end end diff --git a/repository/spec/integration/plugin_spec.rb b/repository/spec/integration/plugin_spec.rb index 641b129be..a500e5f24 100644 --- a/repository/spec/integration/plugin_spec.rb +++ b/repository/spec/integration/plugin_spec.rb @@ -12,7 +12,7 @@ def self.apply(target, **) target.prepend(self) end - def set_relation(*) + def prepare_relation(*) super.where { `1 = 0` } end end