Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/jobs/failed showing wrong ending job # on header #78

Open
palfvin opened this issue Feb 15, 2015 · 0 comments
Open

/jobs/failed showing wrong ending job # on header #78

palfvin opened this issue Feb 15, 2015 · 0 comments

Comments

@palfvin
Copy link

palfvin commented Feb 15, 2015

When listing failing jobs, the upper end of the job range shown in the header is one higher than it should be, due to the header referencing the following:

def failure_end_at
  if failure_start_at + failure_per_page > failure_size
    failure_size
  else
    failure_start_at + failure_per_page
  end
end

Both the pagination and non-pagination cases appear wrong.

Note: This all assumes that the convention of addressing jobs starting with zero is intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant