Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--keep-stage-files --dont-restage fails when used together with sourcesdir #3305

Open
vchuravy opened this issue Nov 4, 2024 · 1 comment · May be fixed by #3393
Open

--keep-stage-files --dont-restage fails when used together with sourcesdir #3305

vchuravy opened this issue Nov 4, 2024 · 1 comment · May be fixed by #3393
Assignees
Milestone

Comments

@vchuravy
Copy link

vchuravy commented Nov 4, 2024

Something like

class MPIWrapper(rfm.CompileOnlyRegressionTest):
    sourcesdir = 'https://github.com/eschnett/MPIwrapper'
    build_system = 'CMake'

fails., when used with --keep-stage-files --dont-restage


Valentin Churavy
  Thursday at 4:38 PM
FAILURE INFO for MPIWrapper ~local:default+julia_1.10 (run: 1/1)
  * Description: 
  * System partition: local
  * Environment: julia_1.10
  * Stage directory: /home/vchuravy/src/trixi-parallel-performance/stage/local/default/julia_1.10/MPIWrapper_e9d9ef7f
  * Node list: 
  * Job type: local (id=None)
  * Dependencies (conceptual): []
  * Dependencies (actual): []
  * Maintainers: []
  * Failing phase: compile
  * Reason: spawned process error: command 'git clone  https://github.com/eschnett/MPIwrapper /home/vchuravy/src/trixi-parallel-performance/stage/local/default/julia_1.10/MPIWrapper_e9d9ef7f' failed with exit code 128:
--- stdout ---
--- stdout ---
--- stderr ---
fatal: destination path '/home/vchuravy/src/trixi-parallel-performance/stage/local/default/julia_1.10/MPIWrapper_e9d9ef7f' already exists and is not an empty directory.
@vkarak
Copy link
Contributor

vkarak commented Nov 27, 2024

I reproduced this. We should skip the clone in case of --dont-restage.

@vkarak vkarak added bug and removed triage labels Nov 27, 2024
@vkarak vkarak modified the milestones: ReFrame 4.8, ReFrame 4.7.4 Feb 4, 2025
@vkarak vkarak self-assigned this Feb 13, 2025
@vkarak vkarak moved this from Todo to In Progress in ReFrame Backlog Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants