Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example directory #172

Closed
Naturalclar opened this issue Oct 9, 2022 · 3 comments
Closed

Add example directory #172

Naturalclar opened this issue Oct 9, 2022 · 3 comments
Labels

Comments

@Naturalclar
Copy link
Contributor

This repo should have an example directory so the repo's features can be tested within the repository.

Use microsoft/react-native-test-app to create an example directory to test masked view

@LRNZ09
Copy link
Contributor

LRNZ09 commented Oct 11, 2022

@Naturalclar are you working on this? Otherwise, I can take a look at it.

EDIT: one problem I see with using microsoft/react-native-test-app is that it doesn't support the Web platform yet, see microsoft/react-native-test-app#812, maybe Expo could be a more straightforward option.

@Naturalclar
Copy link
Contributor Author

Naturalclar commented Oct 12, 2022

@LRNZ09 It'll be great if you can take at look at it 👍

EDIT: one problem I see with using microsoft/react-native-test-app is that it doesn't support the Web platform yet, see microsoft/react-native-test-app#812, maybe Expo could be a more straightforward option.

Thanks for the suggestion! However, unfortunately, expo wouldn't be suitable for an example app for a native module library as expo doesn't support adding native modules that are not supported by the framework.
I'm aware that masked-view is one of the libraries that are supported by expo but I'd like to keep the library flexible

As for the web support, masked-view currently doesn't have a web support so it will be fine for now.
I can make a workaround for web example once web support is implemented

@Naturalclar
Copy link
Contributor Author

Closed via #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants