Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M1 ARM support #49

Open
jianshu93 opened this issue Jan 4, 2022 · 0 comments
Open

M1 ARM support #49

jianshu93 opened this issue Jan 4, 2022 · 0 comments

Comments

@jianshu93
Copy link

Dear Tensor sketch team,

It seems after I changed the #include <immintrin.h> to #include <arm_neon.h>, compiling fails on my m1 MacBook Pro:

[ 33%] Building CXX object CMakeFiles/sketch_lib.dir/sketch/hash_base.cpp.o
In file included from /Users/jianshuzhao/Github/Tensor-sketching/sketch/hash_base.cpp:1:
/Users/jianshuzhao/Github/Tensor-sketching/./sketch/hash_base.hpp: In member function 'T ts::HashBase::hash(uint64_t, uint64_t)':
/Users/jianshuzhao/Github/Tensor-sketching/./sketch/hash_base.hpp:83:32: error:there are no arguments to '_mm_crc32_u32' that depend on a template parameter, so a declaration of '_mm_crc32_u32' must be available [-fpermissive]
83 | uint32_t val = _mm_crc32_u32(hash_seed, (uint32_t)key);
| ^~~~~~~~~~~~~
compilation terminated due to -Wfatal-errors.
make[2]: *** [CMakeFiles/sketch_lib.dir/sketch/hash_base.cpp.o] Error 1
make[1]: *** [CMakeFiles/sketch_lib.dir/all] Error 2
make: *** [all] Error 2

Maybe in the future this can be updated/implenmented

Thanks,

Jianshu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant