-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ArtifactHub package fetching with helm charts #1030
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kravciak I've updated the PR a bit to account for the recent changes from the RFC: kubewarden/rfc#46 It currently will not work properly as the |
Fix #1027
This PR refactors the creation and editiong of policies by shifting from ArtifactHub based templates to a new Policy Chart model.
In addition, several UI components (tables, forms, and editors) have been updated and migrated many components (e.g. admission, Config, Create, PolicyReadmePanel, PolicyTable, Values) to use the
<script setup lang="ts">
syntax.Policy Chart Integration
policyChart
module:Create.vue
,Config.vue
, andPolicyReadmePanel.vue
) to fetch policy details from Policy Charts rather than ArtifactHub packages.PolicyChart
andPolicyDetail
) to represent policy charts and their associated metadata.kubewarden.io/chart-key
kubewarden.io/chart-name
kubewarden.io/chart-version
module
, if not found it will just show the yaml editor for settings.Necessary Policy chart changes
In order to have the Policy Helm charts displayed correctly within the UI, we need to have a few annotations added to each policy:
description
andkeywords
of the chart should also match what we used in theartifacthub-pkg.yaml
.