Enhance KeyValue and Labels shell components to set custom descriptions #13398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
votdev
force-pushed
the
issue_13397_custom_desc_label_keyvalue
branch
from
a29a343 to
558f724
Compare
Allow to set a custom description for the `KeyValue` and `Labels` shell components. Additional add the ability to hide the label description for `Labels`. Related to: rancher#13397 Signed-off-by: Volker Theile <[email protected]>
votdev
force-pushed
the
issue_13397_custom_desc_label_keyvalue
branch
from
558f724 to
8b8d969
Compare
votdev
commented
Feb 13, 2025
| // A custom label description. Defaults to `labels.labels.description` if empty. | ||
| labelDescription: { | ||
| type: String, | ||
| default: '', |
There was a problem hiding this comment.
Would this make sense?
Suggested change
| default: '', | |
| default: 'labels.labels.description', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow to set a custom description for the
KeyValueandLabelsshell components. Additional add the ability to hide the label description forLabels.Fixes: #13397
Occurred changes and/or fixed issues
Add the following new properties:
showLabelDescriptionandlabelDescriptiondescriptionTechnical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist