Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet Epic: Statuses refactoring #13386

Open
torchiaf opened this issue Feb 12, 2025 · 2 comments
Open

Fleet Epic: Statuses refactoring #13386

torchiaf opened this issue Feb 12, 2025 · 2 comments
Assignees
Labels
area/fleet Epic kind/enhancement QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone

Comments

@torchiaf
Copy link
Member

torchiaf commented Feb 12, 2025

Is your feature request related to a problem? Please describe.

We want to revisit the status of each Fleet resource in order to be consistent with the actual resource statuses.

Related issues:

Describe the solution you'd like

  • We should consider to better calculate statuses backend side so that the UI could reduce the effort to normalize data and calculate new statuses
  • UI should calculate statuses considering that we want to implement pagination for some Fleet tables (Dashboard/GitRepo list).

Describe alternatives you've considered

Additional context

@torchiaf torchiaf added this to the v2.12.0 milestone Feb 12, 2025
@torchiaf torchiaf self-assigned this Feb 12, 2025
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Feb 12, 2025
@torchiaf torchiaf modified the milestones: v2.12.0, v2.11.0 Feb 12, 2025
@richard-cox
Copy link
Member

Vai-cache on will impact this in some way

  • when fleet updates to use the new cache (there will be new guidance and docs for this)
    • update lists to use the new paginated table resources with high counts
    • update drop downs that are powered by resources with high counts
    • remove usages of findAll for resource types that have high resource counts
  • this means
    • any new lists that are implemented should only filter/sort on fields that exist in the primary resource (because it will be powered by API request to a single resource type)
    • any new pages / components that are created should avoid using findAll when fetching resources

Some of this might not be possible given the replacement to findAll isn't yet available, but we should plan around it

@richard-cox
Copy link
Member

The state in the ui comes from the resource's metadata.state.name|message. Those are constructed by steve very roughly by kstatus from the resource's conditions (see confluence page Dynamic Resource Properties)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fleet Epic kind/enhancement QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

No branches or pull requests

2 participants